Fix the color of PR comment hyperlinks.#13009
Merged
techknowlogick merged 4 commits intoOct 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13009 +/- ##
==========================================
- Coverage 42.61% 42.48% -0.14%
==========================================
Files 671 671
Lines 73635 73635
==========================================
- Hits 31382 31282 -100
- Misses 37171 37290 +119
+ Partials 5082 5063 -19
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
mrsdizzie
approved these changes
Oct 2, 2020
GiteaBot
added
lgtm/need 1
Member
|
Thanks! |
zeripath
approved these changes
Oct 2, 2020
GiteaBot
added
lgtm/done
bagasme
reviewed
Oct 2, 2020
Contributor
bagasme
left a comment
bagasme
left a comment
There was a problem hiding this comment.
You may want to differentiate link color between unvisited and visited link, something like:
a:visited {
color: something;
}
a:link {
color: other;
}Otherwise, ack.
Member
That shouldn't change (and example above would be a site wide change) and PR is good as is. |
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #12995 by limiting the grey-color span up to cover the comment header only.